"Not sure if that works..."
It's your job as a reviewer to check such things, don't put all the
effort on the author
"You ain't gonna need it."
The fact that you think something is reusable doesn't necessarily mean
it is, and overly general code is harder to maintain
"There is an old bug here."
That fix has nothing to do with the change you are reviewing
"Guess what I mean."
So always provide an example of what you would rather want to see
just type your proposal of how the code should look like
"Not a complete fix."
don't hold the author hostage with your review because you think he
didn't do enough
"Leaving a mark."
You review a change and see that it is mostly fine, but you feel that
since you did so much work reviewing it, you should at least find
*something* wrong. So you find some nitpick and -1 the change just so
that they know you reviewed it.
Just don't do it
оригинал
No comments:
Post a Comment